This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added handling for loading <p><br></p> #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be treated as a block filler even in the nbsp mode.
jodator
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
I've found two typos that changed meaning of the tests.
The second thing is WDYT about adding and explicit check that the data produced by this special case is self-compatible?
The current test checks only downcast conversion AFAIK (setting model in the test) So I'm not sure if this is enough (I feel that I might be missing something here) as I see that this bug touches how DOMConverter handles block fillers and those checks are during upcast conversion.
|
I fixed those issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Type: Fixed a bug when pasting or loading
<p><br></p>would create two lines. Closes ckeditor/ckeditor5#5564.