-
Notifications
You must be signed in to change notification settings - Fork 40
Mutations in UIElements should not be propagated / force render #1811
Conversation
…r will it trigger mutations event on the document.
I think it's much more complicated to test than what you described, Marek. This PR is about changes that are not part of the editing pipeline, but instead come from the external logic and go directly to UIElements or changes that do not translate into mutations on the view tree. The problem is – it can be pretty much everything and it can happen at random moments because it may be done by the browser. Because of that, I'd merge this ASAP and just live with it for some time and see. |
Of course, Kacper and Filip, you can play with a couple of things but I think there are many more things that can go wrong so keep your eyes open :) |
One thing's missing – a note in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented – misses one note in the UIElement#render()
.
Co-Authored-By: Piotrek Koszuliński <pkoszulinski@gmail.com>
Pushed the changes. I'm not entirely sure though if the wording is right so please double check this. |
Suggested merge commit message (convention)
Fix: Change in UIElement view will no longer force a view render nor will it trigger mutations event on the document. Closes ckeditor/ckeditor5#5600.
Additional information
The tests are passing, but this change needs to be carefully tested manually.
I suggest few testing scenario:
Also it's good that we'll be able to merge it at the beginning of iteration, so there's a bigger chance that we'll catch nuances if any appear.