Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6116 #1830

Merged
merged 5 commits into from
Mar 9, 2020
Merged

I/6116 #1830

merged 5 commits into from
Mar 9, 2020

Conversation

Reinmar
Copy link
Member

@Reinmar Reinmar commented Mar 9, 2020

Suggested merge commit message (convention)

Other: Introduced support for multi-range selections. Closes ckeditor/ckeditor5#6116. Closes ckeditor/ckeditor5#2010.


Additional information

Accompanied with:

By far the most tricky part of this task. I had to find the right balance between the deleteContent() (and hence insertContent()) doing reasonable things and overcomplicating them on the cost of maintenance issues and affecting some other cases (mostly: track changes).

By the occam's razor's call I chose the simplest solution – removing code. I removed some quite unnecessary behaviour from deleteContent() and hence was able to use the selection's real position in insertContent().

During the course of action I also stumbled upon a case where the schema's method was leaking out of the limit element and putting selection on a table cell instead. It was visible when pasting a word over multi-cell selection in an empty table. I fixed this too.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 9, 2020

Those changes were reviewed already by @scofalik and @oleq. Merging.

@Reinmar Reinmar merged commit ffce577 into master Mar 9, 2020
@Reinmar Reinmar deleted the i/6116 branch March 9, 2020 22:07
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 100.0% when pulling b67cd98 on i/6116 into 968b193 on master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants