This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ckeditor/ckeditor5#3843.
The problem with selection was that during conversion chain:
DOM -> view (1) -> model -> view (2) -> DOM
view (1) selection was different than view (2) selection because there was a difference how model -> view and DOM -> view selection is converted. This caused an infinite loop of selection fixing.I changed one of conditions that was responsible for breaking the loop. The condition looked whether view (1) and view (2) are equal. Now I check whether they are touching. If they are, the selection is not converted any further.
To do so, I needed to implement
isTouching
in model range, selection and view position, range selection.