Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide h4, h5, h6 as defaultIcons for button view and add translations for items #2468

Closed
MCMicS opened this issue Jan 2, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-heading#124
Closed

Provide h4, h5, h6 as defaultIcons for button view and add translations for items #2468

MCMicS opened this issue Jan 2, 2019 · 5 comments · Fixed by ckeditor/ckeditor5-heading#124
Labels
package:heading type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 22

Comments

@MCMicS
Copy link

MCMicS commented Jan 2, 2019

With ckeditor/ckeditor5-heading#112 the icons for h4 - h6 was provided but in defaultIcons it is still missing.

headingbuttonsui.js

const defaultIcons = {
	heading1: iconHeading1,
	heading2: iconHeading2,
	heading3: iconHeading3
};

Also the translations are only set for Heading 1 to Heading 3
@oleq
Copy link
Member

oleq commented Jan 2, 2019

Why the PR was closed?

@MCMicS
Copy link
Author

MCMicS commented Jan 2, 2019 •
edited
Loading

@oleq I have used wrong author. Have create a new PR. But CLA is missing because I receive no mail for CLA.

@MCMicS MCMicS changed the title Provide h4, h5, h6 as defaultIcons for button view Provide h4, h5, h6 as defaultIcons for button view and add translations for items Jan 2, 2019
jodator referenced this issue in ckeditor/ckeditor5-heading Jan 4, 2019
@jodator
Merge pull request #124 from ckeditor/t/121
17bea3d 
Feature: Provided translations and enabled the default icons to make `heading4`, `heading5`, and `heading6` button components usable (as provided by `HeadingButtonUI`). Closes #121.
@MCMicS
Copy link
Author

MCMicS commented Jan 21, 2019

When will the new messages synchronized with transifex?
Because I can't see them as untranslated there.

@Reinmar
Copy link
Member

Reinmar commented Jan 22, 2019

Sorry! And thanks for reminding us about this. Syncing them right now.

@Reinmar
Copy link
Member

Reinmar commented Jan 22, 2019

Done:

image

We download them back usually before a release.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-heading Oct 9, 2019
@mlewand mlewand added this to the iteration 22 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:heading labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
This was referenced Oct 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:heading type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 22
4 participants
@Reinmar @oleq @MCMicS @mlewand