Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/121: Implemented heading4, heading5, and heading6 button components #124

Merged
merged 6 commits into from
Jan 4, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Jan 3, 2019

Suggested merge commit message (convention)

Feature: Provided translations and enabled the default icons to make heading4, heading5, and heading6 button components usable (as provided by HeadingButtonUI). Closes ckeditor/ckeditor5#2468.


Additional information

I migrated #123 here because I wasn't able to push to the contributor's remote.

@coveralls
Copy link

coveralls commented Jan 3, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 5175878 on t/121 into 65ff154 on master.

@oleq oleq requested a review from jodator January 3, 2019 15:11
tests/headingbuttonsui.js Outdated Show resolved Hide resolved
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleq please update the headingbuttonui tests as you intended to do. For me both options are feasible.

Other then that @MCMicS thanks for original PR and as soon as @oleq will update this nuance we will merge it.

tests/headingbuttonsui.js Outdated Show resolved Hide resolved
@jodator jodator merged commit 17bea3d into master Jan 4, 2019
@jodator jodator deleted the t/121 branch January 4, 2019 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide h4, h5, h6 as defaultIcons for button view and add translations for items
4 participants