This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Other: Update naming of UI components & commands. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
changed the title
|
Heading dropdown doesn't work. |
|
Heading dropdown does work now. |
|
Something got broken here:
|
|
Fancy heading isn't rendered as fancy. |
Reinmar
reviewed
Mar 11, 2018
| const model = this.editor.model; | ||
| const document = model.document; | ||
|
|
||
| const modelElement = options.value; | ||
|
|
||
| if ( !this.modelElements.includes( modelElement ) ) { |
There was a problem hiding this comment.
Such checks cause silent errors. Throw explicitly or let app throw at some point.
There was a problem hiding this comment.
Reported a followup for this: ckeditor/ckeditor5#890
This is caused most likely by ckeditor/ckeditor5-engine#1274, so I'll report a separate ticket for it. I'll also report a separate ticket for these silent checks because they repeat in other packages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Update naming of UI components & commands.
BREAKING CHANGE: Renamed
headingsdrop-down UI component toheading.BREAKING CHANGE: The "heading1", "heading2" and "heading3" commands are no longer available. Replaced by "heading" command that accepts heading model element name as a value.
BREAKING CHANGE: The
HeadingCommand#valueis no longer Boolean - only. Now it can have a name of heading model element.BREAKING CHANGE: The
HeadingCommandconstructor's second parameter is now an array of supported model elements.Additional information
headingncommands in favor ofheadingone command.