This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Remove complete upload icon in Edge #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarwrobel
reviewed
Jul 9, 2018
| @@ -263,4 +264,25 @@ describe( 'ImageUploadProgress', () => { | |||
| '</figure>]' | |||
| ); | |||
| } ); | |||
|
|
|||
| it( 'should not create completeIcon element when browser is Microsoft Edge', () => { | |||
| env.isEdge = true; | |||
There was a problem hiding this comment.
You should use sino#stub. And you should restore the stub after the test. You can use testUtils sandbox (it is automatically restored in aftearEach).
testUtils.sinon.stub( env, 'isEdge' ).returns( true );
|
CC is decreased #220 (comment) |
oskarwrobel
reviewed
Jul 9, 2018
| @@ -209,11 +210,14 @@ function _hideProgressBar( viewFigure, writer ) { | |||
| function _showCompleteIcon( viewFigure, writer, view ) { | |||
| const completeIcon = new UIElement( 'div', { class: 'ck-image-upload-complete-icon' } ); | |||
|
|
|||
| writer.insert( ViewPosition.createAt( viewFigure, 'end' ), completeIcon ); | |||
| // Because in Edge there is no way to show fancy animation of completeIcon we need to skip it. | |||
| if ( !env.isEdge ) { | |||
There was a problem hiding this comment.
I would move this check here https://github.com/ckeditor/ckeditor5-image/pull/220/files#diff-3efbae15fe72a5fbcecff93633200c17R108
|
CI is failing because of https://github.com/ckeditor/ckeditor5-image/issues/221. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Complete upload icon should not be rendered in Edge. Closes ckeditor/ckeditor5/issues/1066.