This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Fix: The image goes beyond the boundaries of the parent block. Closes… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Mar 13, 2017
theme/theme.scss
Outdated
|
|
||
| // Make sure the image never exceeds the size of the parent container (#67). | ||
| max-width: 100%; | ||
| max-height: 100%; |
There was a problem hiding this comment.
Are you sure we need max-height? For me, there is nothing wrong if the long image is longer then editors editable area. Also, it means that a long image will be resized if editable have dynamic height, isn't it?
There was a problem hiding this comment.
Given the editor's height is not restricted by CSS (parent container), then yes. I wouldn't be so sure there is no such case, though. OTOH, you're probably right.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… ckeditor/ckeditor5#5073.
Suggested merge commit message (convention)
Fix: The image goes beyond the boundaries of the parent block. Closes ckeditor/ckeditor5#5073.