Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Use model.insertContent instead of model.Writer.insert #225

Merged
merged 2 commits into from
May 20, 2019
Merged

Use model.insertContent instead of model.Writer.insert #225

merged 2 commits into from
May 20, 2019

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented May 20, 2019 •
edited by pomek
Loading

Suggested merge commit message (convention)

Other: Use model.insertContent instead of model.Writer.insert. Closes ckeditor/ckeditor5#4846.

@coveralls
Copy link

coveralls commented May 20, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c1da028 on t/224 into 5b861a2 on master.

@scofalik scofalik requested a review from pjasiun May 20, 2019 12:28
@pjasiun pjasiun requested a review from Mgsy May 20, 2019 12:55
@pjasiun pjasiun merged commit e3c8676 into master May 20, 2019
@pjasiun pjasiun deleted the t/224 branch May 20, 2019 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mgsy Mgsy Mgsy approved these changes

@pjasiun pjasiun Awaiting requested review from pjasiun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use model.insertContent instead of model.Writer.insert
4 participants
@scofalik @coveralls @Mgsy @pjasiun