Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

i/5746: Link preview in the balloon should have rel="noopener noreferrer" #251

Merged
merged 1 commit into from
Nov 18, 2019
Merged

i/5746: Link preview in the balloon should have rel="noopener noreferrer" #251

merged 1 commit into from
Nov 18, 2019

Conversation

oleq
Copy link
Member

@oleq oleq commented Nov 18, 2019

Suggested merge commit message (convention)

Fix: Link preview in the balloon should have rel="noopener noreferrer" set for security reasons. Closes ckeditor/ckeditor5#5746.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5c46297 on i/5746 into f75bf00 on master.

jodator
jodator approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - I'll wait for fo the CI to merge :)

@jodator jodator merged commit 5b921b4 into master Nov 18, 2019
@jodator jodator deleted the i/5746 branch November 18, 2019 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rel='noopener noreferrer' to the link preview (in the balloon)
3 participants
@oleq @coveralls @jodator