Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckeditor5-react can be published in ES6 #105

Closed
Viktor-the-great opened this issue Aug 8, 2019 · 6 comments · Fixed by #108
Closed

ckeditor5-react can be published in ES6 #105

Viktor-the-great opened this issue Aug 8, 2019 · 6 comments · Fixed by #108
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@Viktor-the-great
Copy link

CKEditor 5 Builds are published in the original ES6 format. If environment requires ES5, I need to transpile CKEditor 5 source to ES5 (ckeditor5 doc).
ckeditor5-react are published in ES5 format, so I need to manually filter ckeditor5-react build (in webpack config).

I think ckeditor5-react Builds should be published in ES6 format like other CKEditor 5 builds.

@Mgsy
Copy link
Member

Mgsy commented Aug 13, 2019

cc @pomek

@pomek
Copy link
Member

pomek commented Aug 13, 2019

I don't see any reason why we couldn't do that.

All that we need to do is just remove @babel/preset-env from the presets array in Webpack configuration.

All tests pass:

Finished in 1.915 secs / 0.509 secs @ 10:08:39 GMT+0200 (Central European Summer Time)

SUMMARY:
✔ 35 tests completed

Will the change be a BC?

@Reinmar, WDYT?

@ma2ciek
Copy link
Contributor

ma2ciek commented Aug 13, 2019

The other question is why you need this transpilation. Because the support for IE11 is still an open issue and currently it does not work.

@Reinmar
Copy link
Member

Reinmar commented Aug 14, 2019

All that we need to do is just remove @babel/preset-env from the presets array in Webpack configuration.

Sounds fine to me. Although, I don't know what kind of implications this will have for people who use CKE5 in CRA apps. I guess none, because CKE5 is already ES6 there, so it already needs to be treated with Terser (instead of Uglify) and hence already require changing the configuration. Is that correct? No documentation changes will be required?

@pomek
Copy link
Member

pomek commented Aug 14, 2019

No documentation changes will be required?

No, we don't need to change anything.

@Reinmar Reinmar added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". labels Aug 20, 2019
@Reinmar
Copy link
Member

Reinmar commented Aug 20, 2019

Let's do it then.

@Reinmar Reinmar added this to the iteration 27 milestone Aug 20, 2019
@pomek pomek self-assigned this Aug 20, 2019
@Reinmar Reinmar changed the title Building to ES5 target ckeditor5-react can be published in ES6 Aug 27, 2019
ma2ciek added a commit that referenced this issue Sep 13, 2019
Other: `<CKEditor>` React component will be distributed in ES6 instead of ES5. Closes #105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants