Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve narrowing of CKEditor CDN configuration type #523

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Sep 9, 2024

Suggested merge commit message (convention)

Feature: Improve result type of useCKEditorCloud to make CKEditorPremiumFeatures and CKBox non-nullable when proper configuration is passed.
Fix: Rename the languages configuration property to translations in useCKEditorCloud.

MINOR BREAKING CHANGE: The languages configuration property has been renamed to translations in useCKEditorCloud.


Additional information

Must be released before testing:
ckeditor/ckeditor5-integrations-common#25

PRs family:
ckeditor/ckeditor5-vue#311

const { CKEditorPremiumFeatures } = await loadCKEditorCloud( {
  version: '43.0.0',
  premium: true,
  ckbox: {
    version: '2.5.1'
  }
} );

Before:

CKEditorPremiumFeatures is nullable type.

After:

CKEditorPremiumFeatures is not nullable type because premium: true is passed.

@coveralls
Copy link

coveralls commented Sep 12, 2024

Pull Request Test Coverage Report for Build e6c91205-231c-40cb-94e3-80e8a2757cf2

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 533e89fd-cb29-46af-8ff9-d95e3b47b910: 0.0%
Covered Lines: 582
Relevant Lines: 582

💛 - Coveralls

Copy link

@gorzelinski gorzelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some nitpicks.

tests/useMultiRootEditor.test.tsx Show resolved Hide resolved
tests/issues/39-frozen browser.test.tsx Outdated Show resolved Hide resolved
tests/cloud/useCKEditorCloud.test.tsx Outdated Show resolved Hide resolved
@Mati365
Copy link
Member Author

Mati365 commented Sep 13, 2024

@gorzelinski done

tests/index.test.tsx Outdated Show resolved Hide resolved
@Mati365 Mati365 merged commit 1268d9e into master Sep 13, 2024
3 of 4 checks passed
@Mati365 Mati365 deleted the ck/narrow-cdn-config branch September 13, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants