-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve narrowing of CKEditor CDN configuration type #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build e6c91205-231c-40cb-94e3-80e8a2757cf2Details
💛 - Coveralls |
gorzelinski
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some nitpicks.
@gorzelinski done |
Mati365
force-pushed
the
ck/narrow-cdn-config
branch
from
September 13, 2024 08:18
abc50f1
to
bd63a95
Compare
filipsobol
reviewed
Sep 13, 2024
filipsobol
reviewed
Sep 13, 2024
filipsobol
reviewed
Sep 13, 2024
filipsobol
reviewed
Sep 13, 2024
filipsobol
reviewed
Sep 13, 2024
filipsobol
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Improve result type of
useCKEditorCloud
to makeCKEditorPremiumFeatures
andCKBox
non-nullable when proper configuration is passed.Fix: Rename the
languages
configuration property totranslations
inuseCKEditorCloud
.MINOR BREAKING CHANGE: The
languages
configuration property has been renamed totranslations
inuseCKEditorCloud
.Additional information
Must be released before testing:
ckeditor/ckeditor5-integrations-common#25
PRs family:
ckeditor/ckeditor5-vue#311
Before:
CKEditorPremiumFeatures
is nullable type.After:
CKEditorPremiumFeatures
is not nullable type becausepremium: true
is passed.