This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
I/5826: Add a helper to handle custom Ctrl+A behaviour #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
suggested changes
Jan 10, 2020
There was a problem hiding this comment.
R-:
- please use
editor.keystrokesfor adding keystrokes - we have a pattern for this. I don't know if it was designed this way but I can see a benefit of using keystroke handler in reading registered keystrokes in the future - other than that some small code style improvements ;)
…o` to `keystrokes.set` and onSelectAll handler itself
|
OK, I hope I fixed all issues. Also increased test coverage by +0.2% to hit 100% 😄 |
jodator
suggested changes
Jan 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Pressing Ctrl+A when selection range is inside an exception selects text only within an exception in restricted editing. Second Ctrl+A selects entire text in the editor. Closes ckeditor/ckeditor5#5826.