Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Disable horizontal merge between header and body cells. #225

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

aStewartDesign
Copy link
Contributor

Fix: Disable horizontal cell merges between header and body cells. Closes ckeditor/ckeditor5#5744.

NOTE: Prevents merging between column header cells and body cells

Additional information

This assumes this is the direction to take on the issue documented here: ckeditor/ckeditor5#5744

@aStewartDesign
Copy link
Contributor Author

aStewartDesign commented Nov 15, 2019

Where do I submit the CLA? If here works then here it is:
Signed CLA

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fcba087 on aStewartDesign:t/ckeditor5/5744 into 63da06f on ckeditor:master.

Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello again, @aStewartDesign!

Thanks for the PR :)

The only thing that was missing is handling the cases when cells are spanned. Spanned cells always add complexity to the general solution.

I'll link to the commit with the changes for reference when I marge the PR.

@jodator
Copy link
Contributor

jodator commented Nov 20, 2019

@aStewartDesign did you sign the CLA? I've missed this and probably we need this to merge your PR. If you have any problems (probably no email in GH) you can write to us on https://ckeditor.com/contact/ with a link to this PR and we will send you the CLA request manually.

Thanks!

@vokiel
Copy link

vokiel commented Nov 20, 2019

@aStewartDesign we noticed that you've attached the manually signed CLA where we can find your current email (different from the one we got from GH).

If it's not a problem for you, could you please sign the electronic CLA so we will have all in order and confirmed by our electronic signature provider? You should receive link on your email. Thanks!

@aStewartDesign
Copy link
Contributor Author

@vokiel not a problem! All signed and should be good to go. Thank you!

jodator added a commit that referenced this pull request Nov 21, 2019
Fix: The `MergeCellCommand` will not merge column header cells with body cells.
@jodator jodator merged commit fcba087 into ckeditor:master Nov 21, 2019
@jodator
Copy link
Contributor

jodator commented Nov 21, 2019

@aStewartDesign thanks for the input!

The changes that I've mentioned are here: c98cfa6.

@Reinmar
Copy link
Member

Reinmar commented Mar 4, 2020

It turned out that this change caused a quite serious regression: ckeditor/ckeditor5#6368.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging header column cells and body cells results in changed header column row
5 participants