Enlarged link's highlight background. #160
Conversation
theme/ckeditor5-link/link.css
Outdated
| outline: 1px solid var(--ck-color-link-selected-background); | ||
|
|
||
| /* #155. Let's keep the same background inside Highlight feature. */ | ||
| & mark { |
There was a problem hiding this comment.
We shouldn't hardcode something like this. We don't even know whether highlight will produce a <mark> element. Is there a different solution?
There was a problem hiding this comment.
@Reinmar AFAIR this feature is strictly <mark>-only. I don't recall an issue/coment but the outcome was that for highlight feature we provide <mark> always (no way to override).
There was a problem hiding this comment.
@Reinmar We can try .ck-link_selected > * but it can be buggy in the future (quick example: with user markers or comments in collaboration?).
There was a problem hiding this comment.
The problem here is that it's not going to work anyway if we'll have a font color plugin which will set inline styles.
I need to see this live, but I think that perhaps we might just live with markers overriding link's highlight. That's still an acceptable solution to me.
|
Turns out that the proposed style doesn't help – see the text color being reset in part of the link? That's exactly what I'm worried about – bulletproofing this solution is trivial. That's why I'd rather prefer this:
Let's see if anyone will complain. Looking at this now, I'd say that this is even perhaps what people will expect. |
|
|
Suggested merge commit message (convention)
Other: Enlarged background in
.ck-link_selected. Closes ckeditor/ckeditor5#3404.