i/6553: Replace .ck-labeled-input and .ck-labeled-view classes with .ck-label-field-view #276
Conversation
| @@ -29,7 +29,7 @@ | |||
| padding: 0; | |||
| width: calc(.8 * var(--ck-input-text-width)); | |||
|
|
|||
| & .ck-labeled-input { | |||
| & .ck-labeled-field-view { | |||
There was a problem hiding this comment.
Something's wrong with the media form
and when I remove this rule it goes back to normal:
but I see that all forms (link, text alternative) have this style and it works.
Anyway, it is caused by the status text which does not wrap to the next line and removing it "fixes" the problem
Why it worked before?
There was a problem hiding this comment.
We also lost all the colors and font size in the status:
Expected:
Actual:
It could be that because the font was smaller, issues I mentioned in my previous comment were never visible.
There was a problem hiding this comment.
Same in the table props dialog, font size is wrong
| @@ -38,7 +38,7 @@ | |||
| } | |||
|
|
|||
| /* Let the long error messages wrap in the narrow form. */ | |||
| & .ck-labeled-input__error { | |||
| & .ck-labeled-field-view__error { | |||
There was a problem hiding this comment.
Shouldn't it also work for non-error statuses?
|
OK, I see what was wrong. I forgot to fix the dir path, so the styles didn't apply. Now everything should work fine. |
Suggested merge commit message (convention)
Fix: Replaced
.ck-labeled-inputand.ck-labeled-viewclasses with.ck-labeled-field-view. See ckeditor/ckeditor5#6553.Additional information
These changes fix missing styles after merging ckeditor/ckeditor5/issues/6110.