Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Safari] Selection lands at the beginning of corrected word after using spell checker #3061

Closed
Reinmar opened this issue Oct 17, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-typing#88
Closed

[Safari] Selection lands at the beginning of corrected word after using spell checker #3061

Reinmar opened this issue Oct 17, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-typing#88
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 9

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 17, 2016

oct-17-2016 14-28-01

I tested it after we closed ckeditor/ckeditor5-typing#53.

It also doesn't work great in Firefox, but at least the selection that you get is the position of selection when you open the context menu. So this makes some sense. What you get in Safari doesn't make sense though.
f1ames referenced this issue in ckeditor/ckeditor5-typing Mar 13, 2017
@f1ames
Merge pull request #88 from ckeditor/t/86
0766407 
Fix: `InputCommand` now accepts `Range` instead of `Position` as a parameter. Closes #86. Closes #54.
BREAKING CHANGE: `InputCommand` `options.resultPosition` was replaced with `options.resultRange`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-typing Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:typing labels Oct 9, 2019
@f1ames f1ames mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:typing type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

T/86 InputCommand should accept range instead of position as a parameter. ckeditor/ckeditor5-typing
2 participants
@Reinmar @mlewand