This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/86 InputCommand should accept range instead of position as a parameter. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Mar 13, 2017
tests/manual/86/1.js
Outdated
| /* globals console, window, document */ | ||
|
|
||
| import ClassicEditor from '@ckeditor/ckeditor5-editor-classic/src/classic'; | ||
| import Enter from '@ckeditor/ckeditor5-enter/src/enter'; |
There was a problem hiding this comment.
Use the essential preset + paragraph instead of these 4 plugins.
There was a problem hiding this comment.
You can also update all other manual tests.
|
Two things:
Other than that, everything works fine, so you can merge the ticket (don't forget to copy the message) once you fix the tests. |
|
Ok, manual tests updated to use essentials preset. Added 2 unit tests covering |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
InputCommandnow acceptsRangeinstead ofPositionas a parameter. Closes ckeditor/ckeditor5#3082. Closes ckeditor/ckeditor5#3061.BREAKING CHANGE:
InputCommandoptions.resultPositionwas replaced withoptions.resultRange.Additional information
This fixes ckeditor/ckeditor5#3061, however in a way it works now same as natively in Safari - after correction the whole word is selected.