This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/61: Backspace on a fully selected content or at the beginning of the first block should ensure that paragraph is left #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Jul 5, 2017
tests/inputcommand-integration.js
Outdated
| @@ -175,7 +176,7 @@ describe( 'InputCommand integration', () => { | |||
| '<p>Foo1</p><p>Bar2{}</p>' ); | |||
| } ); | |||
|
|
|||
| it( 'resets the buffer when attribute changes', () => { | |||
| xit( 'resets the buffer when attribute changes', () => { | |||
… first block will ensure that paragraph is left.
|
And what about backspace at the beginning of the first block? |
|
A case to check: whether attributes of the block in which the selection is located initially don't leak to the paragraph created afterwards. |
|
Let's remove this PR because it still requires some thinking what we want to achieve and some major changes in the implementation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Backspace on a fully selected content or at the beginning of the first block will ensure that paragraph is left. Closes ckeditor/ckeditor5#3065.