This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added TextInputView#isReadOnly state. #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
reviewed
Jul 7, 2017
| * @observable | ||
| * @member {Boolean} #isReadOnly | ||
| */ | ||
| this.set( 'isReadOnly', false ); |
There was a problem hiding this comment.
Shouldn't LabeledInputView also implement it? I think the state may also affect the label/entire field in general (like changing the color of the label). readonly is common for all inputs so I guess LabeledInputView should interface it for all inputs.
There was a problem hiding this comment.
Done. I added only a state. I didn't add any CSS class reflecting this state.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added
TextInputView#isReadOnlyandLabeledInputView#isReadOnlystates. Closes ckeditor/ckeditor5#5386. Closes ckeditor/ckeditor5#5385.