Merge pull request #31 from ckeditor/t/30

Other: Optional notification title when upload fails. Closes #30.
ckeditor · Jun 5, 2017 · 1a6306c · 1a6306c
2 parents 66978f5 + f0e3a8c
commit 1a6306c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/lang/contexts.json b/lang/contexts.json
@@ -1,3 +1,4 @@
 {
-	"Insert image": "Label for the insert image toolbar button."
+	"Insert image": "Label for the insert image toolbar button.",
+	"Upload failed": "Title of the notification displayed when upload fails."
 }
diff --git a/src/imageuploadengine.js b/src/imageuploadengine.js
@@ -93,6 +93,7 @@ export default class ImageUploadEngine extends Plugin {
 	 */
 	load( loader, batch, imageElement ) {
 		const editor = this.editor;
+		const t = editor.locale.t;
 		const doc = editor.document;
 		const fileRepository = editor.plugins.get( FileRepository );
 		const notification = editor.plugins.get( Notification );
@@ -127,7 +128,10 @@ export default class ImageUploadEngine extends Plugin {
 			.catch( msg => {
 				// Might be 'aborted'.
 				if ( loader.status == 'error' ) {
-					notification.showWarning( msg, { namespace: 'upload' } );
+					notification.showWarning( msg, {
+						title: t( 'Upload failed' ),
+						namespace: 'upload'
+					} );
 				}
 
 				clean();

diff --git a/tests/imageuploadengine.js b/tests/imageuploadengine.js
@@ -150,6 +150,7 @@ describe( 'ImageUploadEngine', () => {
 
 		notification.on( 'show:warning', ( evt, data ) => {
 			expect( data.message ).to.equal( 'Reading error.' );
+			expect( data.title ).to.equal( 'Upload failed' );
 			evt.stop();
 
 			done();