Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Introduce assertEqualMarkup() test util #302

Merged
merged 7 commits into from
Sep 17, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Sep 6, 2019

Suggested merge commit message (convention)

Feature: Introduce assertEqualMarkup() test util method. Closes ckeditor/ckeditor5#2514.


Additional information

  • I'll check if we can use it somewhere else other then PFO - tables?
  • 2 New dev dependencies:

Required by ckeditor/ckeditor5-engine#1779

@coveralls
Copy link

coveralls commented Sep 9, 2019

Coverage Status

Coverage remained the same at 99.828% when pulling c0c7d5f on t/ckeditor5-paste-from-office/14 into 36db591 on master.

@Reinmar
Copy link
Member

Reinmar commented Sep 17, 2019

2 New dev dependencies:
*

Interestingly, we already used both because I didn't have to install anything.

@Reinmar
Copy link
Member

Reinmar commented Sep 17, 2019

This looks really cool:

image

@Reinmar Reinmar merged commit ee1655f into master Sep 17, 2019
@Reinmar Reinmar deleted the t/ckeditor5-paste-from-office/14 branch September 17, 2019 08:00
@Reinmar
Copy link
Member

Reinmar commented Sep 17, 2019

The trick used to replace <$text> elements is a bit ugly (it creates invalid HTML because we also need to take care of closing tags). But if it works, it's fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests actual vs expected output is hardly readable
3 participants