Merge pull request #27 from ckeditor/t/24

Internal: Made the missing context error an internal warning. Closes #24.
ckeditor · Oct 3, 2019 · 565e1aa · 565e1aa
2 parents 5a9dc0c + 73844f3
commit 565e1aa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 37 deletions.
diff --git a/src/watchdog.js b/src/watchdog.js
@@ -345,9 +345,9 @@ export default class Watchdog {
 	 * @param {ErrorEvent|PromiseRejectionEvent} evt Error event.
 	 */
 	_handleError( error, evt ) {
-		if ( error.is && error.is( 'CKEditorError' ) && error.context === undefined ) {
-			console.error( 'The error is missing its context and Watchdog cannot restart the proper editor.' );
-		}
+		// @if CK_DEBUG // if ( error.is && error.is( 'CKEditorError' ) && error.context === undefined ) {
+		// @if CK_DEBUG // console.warn( 'The error is missing its context and Watchdog cannot restart the proper editor.' );
+		// @if CK_DEBUG // }
 
 		if ( this._shouldReactToError( error ) ) {
 			this.crashes.push( {

diff --git a/tests/watchdog.js b/tests/watchdog.js
@@ -466,37 +466,6 @@ describe( 'Watchdog', () => {
 			} );
 		} );
 
-		it( 'Watchdog should warn if the CKEditorError missing its context', () => {
-			const watchdog = new Watchdog();
-
-			watchdog.setCreator( ( el, config ) => ClassicTestEditor.create( el, config ) );
-
-			// sinon.stub( window, 'onerror' ).value( undefined ); and similar do not work.
-			const originalErrorHandler = window.onerror;
-			window.onerror = undefined;
-
-			sinon.stub( console, 'error' );
-
-			return watchdog.create( element ).then( () => {
-				setTimeout( () => throwCKEditorError( 'foo' ) );
-
-				return new Promise( res => {
-					setTimeout( () => {
-						window.onerror = originalErrorHandler;
-
-						expect( watchdog.crashes ).to.deep.equal( [] );
-
-						sinon.assert.calledWithExactly(
-							console.error,
-							'The error is missing its context and Watchdog cannot restart the proper editor.'
-						);
-
-						watchdog.destroy().then( res );
-					} );
-				} );
-			} );
-		} );
-
 		it( 'Watchdog should omit error if the CKEditorError context is equal to null', () => {
 			const watchdog = new Watchdog();
 
@@ -506,8 +475,6 @@ describe( 'Watchdog', () => {
 			const originalErrorHandler = window.onerror;
 			window.onerror = undefined;
 
-			sinon.stub( console, 'error' );
-
 			return watchdog.create( element ).then( () => {
 				setTimeout( () => throwCKEditorError( 'foo', null ) );
 
@@ -516,7 +483,6 @@ describe( 'Watchdog', () => {
 						window.onerror = originalErrorHandler;
 
 						expect( watchdog.crashes ).to.deep.equal( [] );
-						sinon.assert.notCalled( console.error );
 
 						watchdog.destroy().then( res );
 					} );