This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Fixed image resize flashing unexpected size #112
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
22668d9
Fix: Fixed a case where image would get a full width just by clicking…
mlewand 2c874d7
Internal: Slightly different way of avoiding commit execution when th…
mlewand 4fbf26c
PoC for the resizer operating on views rather than on DOM directly.
mlewand 68044f0
Removed one leftover.
mlewand 146d262
Checkpoint.
mlewand ac53c67
Checkpoint.
mlewand 32268ac
Removed unused code.
mlewand b1142c6
Internal: Simplified the API. Now resizer options take an editor inst…
mlewand 6f79f2c
Internal: Further cleanup after API adjustment.
mlewand 8bf0a01
Docs: Minor rewording in the docs.
mlewand 3c72995
Internal: Renamed the _viewResizerWrapper property and adjusted API d…
mlewand 24767b6
Internal: ResizerOptions interface no longer has the downcastWriter p…
mlewand dc2d463
Internal: Hide the widget toolbar during resize to improve the perfor…
mlewand ac2881f
Merge branch 'master' into i/5189
mlewand 02a71f8
Internal: Perform a soft-check on WidgetToolbarRepository plugin, so …
mlewand 974c58d
Internal: Adjusted priorities to make sure that the toolbar is always…
mlewand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "view" doesn't mean that it's a view but it comes from the view so it's an adjective and should be the first word. Just like in the variable which you actually use below:
Next to the
viewResizerWrapper
you have adomResizerWrapper
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the description of this property.