Merge pull request #293 from ckeditor/i/6501

Other: Removed temporary fixes for `model-selection-range-intersects` errors. See #6501. See #6382.
ckeditor · Apr 14, 2020 · 6363099 · 6363099
2 parents 84abbb8 + f476ba7
commit 6363099
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/packages/ckeditor5-table/src/commands/mergecellscommand.js b/packages/ckeditor5-table/src/commands/mergecellscommand.js
@@ -47,9 +47,6 @@ export default class MergeCellsCommand extends Command {
 			// All cells will be merge into the first one.
 			const firstTableCell = selectedTableCells.shift();
 
-			// This prevents the "model-selection-range-intersects" error, caused by removing row selected cells.
-			writer.setSelection( firstTableCell, 'on' );
-
 			// Update target cell dimensions.
 			const { mergeWidth, mergeHeight } = getMergeDimensions( firstTableCell, selectedTableCells, tableUtils );
 			updateNumericAttribute( 'colspan', mergeWidth, firstTableCell, writer );

diff --git a/packages/ckeditor5-table/src/commands/removecolumncommand.js b/packages/ckeditor5-table/src/commands/removecolumncommand.js
@@ -65,9 +65,6 @@ export default class RemoveColumnCommand extends Command {
 		const cellToFocus = getCellToFocus( tableMap, firstCell, lastCell, removedColumnIndexes );
 
 		this.editor.model.change( writer => {
-			// A temporary workaround to avoid the "model-selection-range-intersects" error.
-			writer.setSelection( writer.createRangeOn( table ) );
-
 			const columnsToRemove = removedColumnIndexes.last - removedColumnIndexes.first + 1;
 
 			this.editor.plugins.get( 'TableUtils' ).removeColumns( table, {