Merge pull request #6753 from ckeditor/i/6702

Other (table): Changed insert row above/below buttons order in the table dropdown. Closes #6702.
ckeditor · May 7, 2020 · a78bca8 · a78bca8
2 parents 5e79676 + 869f122
commit a78bca8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/ckeditor5-table/src/tableui.js b/packages/ckeditor5-table/src/tableui.js
@@ -141,15 +141,15 @@ export default class TableUI extends Plugin {
 				{
 					type: 'button',
 					model: {
-						commandName: 'insertTableRowBelow',
-						label: t( 'Insert row below' )
+						commandName: 'insertTableRowAbove',
+						label: t( 'Insert row above' )
 					}
 				},
 				{
 					type: 'button',
 					model: {
-						commandName: 'insertTableRowAbove',
-						label: t( 'Insert row above' )
+						commandName: 'insertTableRowBelow',
+						label: t( 'Insert row below' )
 					}
 				},
 				{

diff --git a/packages/ckeditor5-table/tests/tableui.js b/packages/ckeditor5-table/tests/tableui.js
@@ -139,7 +139,7 @@ describe( 'TableUI', () => {
 			const labels = listView.items.map( item => item instanceof ListSeparatorView ? '|' : item.children.first.label );
 
 			expect( labels ).to.deep.equal(
-				[ 'Header row', '|', 'Insert row below', 'Insert row above', 'Delete row', 'Select row' ]
+				[ 'Header row', '|', 'Insert row above', 'Insert row below', 'Delete row', 'Select row' ]
 			);
 		} );
 
@@ -170,12 +170,12 @@ describe( 'TableUI', () => {
 			expect( items.first.children.first.isEnabled ).to.be.false;
 			expect( dropdown.buttonView.isEnabled ).to.be.true;
 
-			insertRowBelowCommand.isEnabled = false;
+			insertRowAboveCommand.isEnabled = false;
 
 			expect( items.get( 2 ).children.first.isEnabled ).to.be.false;
 			expect( dropdown.buttonView.isEnabled ).to.be.true;
 
-			insertRowAboveCommand.isEnabled = false;
+			insertRowBelowCommand.isEnabled = false;
 			expect( items.get( 3 ).children.first.isEnabled ).to.be.false;
 			expect( dropdown.buttonView.isEnabled ).to.be.true;