Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut down the search time by X by not using model.change() to mark each result #10302

Closed
Reinmar opened this issue Aug 4, 2021 · 0 comments · Fixed by #10457
Closed

Cut down the search time by X by not using model.change() to mark each result #10302

Reinmar opened this issue Aug 4, 2021 · 0 comments · Fixed by #10457
Assignees
@arkflpc
Labels
package:find-and-replace squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 47 (v30...

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 4, 2021 •
edited
Loading

Extracted from #10022. See @oleq's comments

Scope: Use one model.change() (outside the loop)
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. package:find-and-replace type:improvement This issue reports a possible enhancement of an existing feature. labels Aug 4, 2021
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 46 Aug 4, 2021
@Reinmar Reinmar removed this from the iteration 46 milestone Aug 16, 2021
@Reinmar Reinmar added this to the iteration 47 milestone Aug 30, 2021
@arkflpc arkflpc self-assigned this Aug 30, 2021
@arkflpc arkflpc mentioned this issue Aug 31, 2021
Merged
oleq added a commit that referenced this issue Aug 31, 2021
@oleq
Merge pull request #10457 from ckeditor/ck/10302
8d425ed 
Fix (find-and-replace): Improved the performance of the find feature by reducing the number of `model.change()` calls. Closes #10302.
@AnnaTomanek AnnaTomanek mentioned this issue Sep 6, 2021
Closed
@Reinmar Reinmar mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arkflpc arkflpc

Labels
package:find-and-replace squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 47 (v30.0.0)
Development

Successfully merging a pull request may close this issue.

Move model.change() outside the loop ckeditor/ckeditor5
2 participants
@Reinmar @arkflpc