Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar loses focus after escaping from the find and replace dropdown #10420

Closed
niegowski opened this issue Aug 25, 2021 · 0 comments · Fixed by #10523
Closed

Toolbar loses focus after escaping from the find and replace dropdown #10420

niegowski opened this issue Aug 25, 2021 · 0 comments · Fixed by #10523
Assignees
@mateuszzagorski
Labels
domain:accessibility This issue reports an accessibility problem. package:find-and-replace squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 47 (v30...

Comments

@niegowski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. http://fake.ckeditor.com:8081/build/docs/ckeditor5/latest/features/find-and-replace.html
  2. press Alt+F10
  3. use arrow keys to move to find and replace button
  4. hit enter or arrow down to open dialog
  5. hit esc to move focus back to the toolbar

✔️ Expected result

The toolbar stays focused

❌ Actual result

Toolbar loses focus

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

  • Browser: …
  • OS: …
  • First affected CKEditor version: …
  • Installed CKEditor plugins: …

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@niegowski niegowski added type:bug This issue reports a buggy (incorrect) behavior. domain:accessibility This issue reports an accessibility problem. squad:core Issue to be handled by the Core team. release:potential-blocker This issue potentially blocks the upcoming release (should be checked). package:find-and-replace labels Aug 25, 2021
@Reinmar Reinmar removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Aug 25, 2021
@mlewand mlewand added squad:features Issue to be handled by the Features team. and removed squad:core Issue to be handled by the Core team. labels Sep 13, 2021
@mlewand mlewand added this to the iteration 47 milestone Sep 13, 2021
@AnnaTomanek AnnaTomanek changed the title Toolbar looses focus after escaping from the find and replace dropdown Toolbar loses focus after escaping from the find and replace dropdown Sep 13, 2021
@AnnaTomanek AnnaTomanek mentioned this issue Sep 13, 2021
Closed
@mateuszzagorski mateuszzagorski mentioned this issue Sep 13, 2021
Merged
mlewand added a commit that referenced this issue Sep 14, 2021
@mlewand
Fix (find-and-replace): The toolbar should not lose the focus after e…
a5e0392 
…scaping from the find and replace dropdown. Closes #10420.

Fixing focus after escaping find and replace dropdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateuszzagorski mateuszzagorski

Labels
domain:accessibility This issue reports an accessibility problem. package:find-and-replace squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 47 (v30.0.0)
Development

Successfully merging a pull request may close this issue.

Fixing focus after escaping find and replace dropdown ckeditor/ckeditor5
4 participants
@Reinmar @niegowski @mlewand @mateuszzagorski