Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repetitive and non-informative editor's label #11836

Closed
Comandeer opened this issue May 27, 2022 · 1 comment · Fixed by #11976
Closed

Repetitive and non-informative editor's label #11836

Comandeer opened this issue May 27, 2022 · 1 comment · Fixed by #11976
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Comandeer
Copy link
Member

Comandeer commented May 27, 2022

📝 Provide detailed reproduction steps (if any)

  1. Open https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html
  2. Launch VoiceOver (or some other screen reader).
  3. Focus the editor.

✔️ Expected result

The editor is announced in a concise and non-redundant way.

❌ Actual result

The editor is announced as "Rich Text Editor, <root name>, edit text. <content and selection info>. Rich Text Editor, application.

❓ Possible solution

Both labels – for the application region and editable ones – should be different and easily differentiated. See CKE4's implementation as an example.

📃 Other details

  • Browser: all
  • OS: all
  • Installed CKEditor plugins: N/A

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Comandeer Comandeer added type:bug This issue reports a buggy (incorrect) behavior. domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. labels May 27, 2022
@mlewand
Copy link
Contributor

mlewand commented Jun 1, 2022

In NVDA or JAWS the readout is even worse as it goes

"Rich text editor, Rich text editor (...)"

Reason for this is that both textbox and application element have the same label.

The solution for now is to remove "Rich Text Editor" prefix from textbox's label (as it is inherited from role=application element).

@mateuszzagorski mateuszzagorski self-assigned this Jun 27, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 27, 2022
@oleq oleq self-assigned this Jul 11, 2022
oleq added a commit that referenced this issue Jul 13, 2022
Fix (editor-balloon, editor-inline, editor-classic, editor-decoupled, ui): The editing area of the editor should have a clear accessible label. Closes #11836.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 13, 2022
@Reinmar Reinmar added this to the iteration 55 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants