Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media embed and tables to all builds #1247

Closed
6 tasks done
Reinmar opened this issue Sep 17, 2018 · 8 comments
Closed
6 tasks done

Add media embed and tables to all builds #1247

Reinmar opened this issue Sep 17, 2018 · 8 comments
Assignees
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 17, 2018

  • Add them to the builds themselves.
    • Find the space for them in the toolbars.
    • Change builds configuration.
  • Update examples (and demos) of these builds to showcase the new features. (Consult @m-kr and @gok9ok about the content.)
  • Check out the "Installation" sections of these features docs. There were notes like "This feature is not available in the builds..." which needs to be changed (take inspiration from guides of the features that are included).
  • Update screenshots in https://ckeditor.com/docs/ckeditor5/latest/builds/guides/overview.html.

Did I forget about something?

@Reinmar Reinmar added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed labels Sep 17, 2018
@Reinmar Reinmar added this to the iteration 20 milestone Sep 17, 2018
@oleq
Copy link
Member

oleq commented Sep 20, 2018

Just for the record, I increased the priority of this issue

image

because as the toolbars grow (e.g. addition of the media-embed dropdown), this issue becomes visible even more.

@oleq
Copy link
Member

oleq commented Sep 20, 2018

We also need to start looking for solutions for #894

image

image

because if overcrowded toolbars in the classic/document do wrap to the next line, there's no such thing in the balloon editor. And this becomes a problem because no matter what, there's no way to position the balloon to fit the toolbar in the viewport in some situations because it's just too wide.

@gok9ok
Copy link

gok9ok commented Sep 20, 2018

Update examples (and demos) of these builds to showcase the new features.

I can provide the content by midweek next week at best since I'm pretty overloaded right now. 😅 hope that's okay

@oleq
Copy link
Member

oleq commented Sep 20, 2018

@gok9ok Sounds good to me. @Reinmar, does it make sense for the roadmap?


I'll be able to update the build screenshots when

Find the space for them in the toolbars.

is approved by the reviewer.

The constellation is here #1254.

Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Sep 24, 2018
Feature: Added the table and media embed features to the build. See ckeditor/ckeditor5#1247.
Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Sep 24, 2018
Feature: Added the table and media embed features to the build. See ckeditor/ckeditor5#1247.
Reinmar added a commit to ckeditor/ckeditor5-build-decoupled-document that referenced this issue Sep 24, 2018
Feature: Added the table and media embed features to the build. See ckeditor/ckeditor5#1247.
Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Sep 24, 2018
Feature: Added the table and media embed features to the build. See ckeditor/ckeditor5#1247.
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Sep 24, 2018
Feature: Added the table feature to the build. See ckeditor/ckeditor5#1247.
Reinmar added a commit that referenced this issue Sep 25, 2018
Docs: Updated build screenshots in Builds/Overview. Updated page styles to prevent toolbar wrapping in the document editor sample. See #1247.
@Reinmar
Copy link
Member Author

Reinmar commented Sep 25, 2018

I merged everything. The remaining thing is updating the content.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 7, 2018

Let's keep this open to not forget about updating the content of editor demos.

@Reinmar Reinmar reopened this Oct 7, 2018
@Reinmar Reinmar modified the milestones: iteration 20, iteration 21 Oct 15, 2018
@oleq
Copy link
Member

oleq commented Oct 16, 2018

Just FYI #1247 (comment) has been addressed in https://github.com/ckeditor/ckeditor5-ui/issues/123

oleq added a commit that referenced this issue Oct 26, 2018
@oleq
Copy link
Member

oleq commented Oct 26, 2018

Updated the content of the build examples in b18b18c.

@oleq oleq closed this as completed Oct 26, 2018
JDinABox pushed a commit to JDinABox/ckeditor5-build-markdown that referenced this issue Sep 6, 2021
Feature: Added the table and media embed features to the build. See ckeditor/ckeditor5#1247.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

3 participants