Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style dropdown] Add styles to <table> and its elements #13777

Closed
Witoso opened this issue Mar 28, 2023 · 1 comment · Fixed by #13937
Closed

[Style dropdown] Add styles to <table> and its elements #13777

Witoso opened this issue Mar 28, 2023 · 1 comment · Fixed by #13937
Assignees
@mremiszewski
Labels
package:style squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 63 (v38...

Comments

@Witoso
Copy link
Member

Witoso commented Mar 28, 2023 •
edited
Loading

Add a missing integration of Style dropdown with tables

Let's support:

  • <table>,<tr>,<th>, <td>,
  • <caption>, <figcaption>

Let's skip:

  • <tfoot>, <col> / <colgroup>.
  • <thead>, <tbody>.
    as we treat those elements as complex, and it would take a lot of time to implement those.

The acceptance criteria go as follows:

  1. given I have a defined style definition for table when I select the table widget and apply the defined table style, then the style is applied to the table element.
  2. given I have a defined style definition for table or tr or th or td when I select one cell, multiple cells, or multiple rows, and apply the defined one or more styles, then the style is applied to the exact elements.
  3. given I have a defined style definition for <caption> or <figcaption> when I select the caption elements and apply the defined caption style, then the style is applied to the elements.
@Witoso Witoso added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. package:style labels Mar 28, 2023
@Witoso Witoso changed the title [SD] Add styles to <table> and its elements [Style dropdown] Add styles to <table> and its elements Mar 28, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Mar 29, 2023
@mremiszewski mremiszewski self-assigned this Mar 31, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 31, 2023
@mremiszewski mremiszewski mentioned this issue Apr 20, 2023
Merged
@wimleers
Copy link

This would fix https://www.drupal.org/project/drupal/issues/3356593.

arkflpc added a commit that referenced this issue Apr 28, 2023
@arkflpc
Merge pull request #13937 from ckeditor/ck/13777-add-styles-to-table
92b418d 
Feature (style): Add custom styling support for td, th, caption and figcaption elements. Closes #13777.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 28, 2023
@CKEditorBot CKEditorBot added this to the iteration 63 milestone Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mremiszewski mremiszewski

Labels
package:style squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 63 (v38.0.0)
Development

Successfully merging a pull request may close this issue.

Ck/13777 add styles to table ckeditor/ckeditor5
4 participants
@wimleers @Witoso @CKEditorBot @mremiszewski