Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor crashes when pasting table from Google Sheets with full GHS configuration #13876

Closed
Witoso opened this issue Apr 13, 2023 · 0 comments · Fixed by #13915
Closed

Editor crashes when pasting table from Google Sheets with full GHS configuration #13876

Witoso opened this issue Apr 13, 2023 · 0 comments · Fixed by #13915
Assignees
@filipsobol
Labels
package:html-support package:table squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 63 (v38...

Comments

@Witoso
Copy link
Member

Witoso commented Apr 13, 2023

📝 Provide detailed reproduction steps (if any)

  1. Enable full GHS config.
htmlSupport: {
  allow: [
      {
          name: /.*/,
          attributes: true,
          classes: true,
          styles: true
      }
  ]
}
  1. Paste table from Google Sheets.

✔️ Expected result

Table appears.

❌ Actual result

Editor crashes.

❓ Possible solution

If you have ideas, you can list them here. Otherwise, you can delete this section.

📃 Other details

More details: #13746

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Witoso Witoso added type:bug This issue reports a buggy (incorrect) behavior. package:table squad:core Issue to be handled by the Core team. package:html-support labels Apr 13, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Apr 13, 2023
@Witoso Witoso mentioned this issue Apr 13, 2023
Closed
@filipsobol filipsobol self-assigned this Apr 17, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Apr 17, 2023
filipsobol added a commit that referenced this issue Apr 19, 2023
@filipsobol
Add test to cover bug reported in #13876
dc5a185
@filipsobol filipsobol mentioned this issue Apr 19, 2023
Merged
arkflpc added a commit that referenced this issue Apr 21, 2023
@arkflpc
Merge pull request #13915 from ckeditor/ck/13876-improve-google-sheet…
2abd9ff 
…s-support

Fix (html-support): Fix editor crashes when pasting table from Google Sheets. Closes #13876.

Fix (paste-from-office): Fix width of tables pasted from Google Sheets. Closes #13746.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 21, 2023
@CKEditorBot CKEditorBot added this to the iteration 63 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipsobol filipsobol

Labels
package:html-support package:table squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 63 (v38.0.0)
Development

Successfully merging a pull request may close this issue.

Improve Google Sheets support ckeditor/ckeditor5
3 participants
@filipsobol @Witoso @CKEditorBot