Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drag & drop, intro] Prevent dropping in the impossible places (a.k.a. inception) #14709

Closed
Tracked by #13933
Witoso opened this issue Aug 2, 2023 · 3 comments · Fixed by #15012
Closed
Tracked by #13933

[Drag & drop, intro] Prevent dropping in the impossible places (a.k.a. inception) #14709

Witoso opened this issue Aug 2, 2023 · 3 comments · Fixed by #15012
Assignees
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Witoso
Copy link
Member

Witoso commented Aug 2, 2023

📝 Provide detailed reproduction steps (if any)

Don’t show the drop target inside the element that is selected or where you cannot place it, examples:

  1. Table into itself,
  2. Block quote into itself.
  3. Inline image to block's image caption.

✔️ Expected result

Drop target line doesn't show.

❌ Actual result

Drop target line does show.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Witoso Witoso added type:bug This issue reports a buggy (incorrect) behavior. squad:core Issue to be handled by the Core team. package:clipboard labels Aug 2, 2023
@Witoso Witoso mentioned this issue Jul 24, 2023
16 tasks
@Witoso Witoso changed the title [Drag & drop] Prevent dropping in the [Drag & drop] Prevent dropping in the impossible places (a.k.a inception) Aug 2, 2023
@Witoso Witoso changed the title [Drag & drop] Prevent dropping in the impossible places (a.k.a inception) [Drag & drop] Prevent dropping in the impossible places (a.k.a. inception) Aug 2, 2023
@pranavmappoli
Copy link

@Witoso ,
I feel inline element to itself also need to blocked.see here

we can drop a inline element over other. Is there any temporary solution available for this ?

@Witoso
Copy link
Member Author

Witoso commented Aug 3, 2023

Replacement via drag & drop is a standard behavior, so the issue won't change this.

@pranavmappoli
Copy link

@Witoso , Is there any way to block this behavior?. if something dropped on the span, it should get rejected.

@Witoso Witoso changed the title [Drag & drop] Prevent dropping in the impossible places (a.k.a. inception) [Drag & drop, intro] Prevent dropping in the impossible places (a.k.a. inception) Aug 21, 2023
@filipsobol filipsobol self-assigned this Sep 7, 2023
@filipsobol filipsobol added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 7, 2023
@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 7, 2023
arkflpc added a commit that referenced this issue Oct 11, 2023
…disallowed-places

Fix (clipboard): Improved drop marker visibility to only display in permissible drop locations. Closes #14709.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 11, 2023
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants