Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the URL editing of the CKBox/Responsive image #15093

Closed
Witoso opened this issue Sep 28, 2023 · 0 comments · Fixed by #15135
Closed

Fix the URL editing of the CKBox/Responsive image #15093

Witoso opened this issue Sep 28, 2023 · 0 comments · Fixed by #15135
Assignees
@pszczesniak @illia-stv
Labels
package:ckbox package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 68 (v40...

Comments

@Witoso
Copy link
Member

Witoso commented Sep 28, 2023 •
edited
Loading

Replacing the URL of the image, should replace the image itself. Looks like this was already planned but is not working:

ckeditor5/packages/ckeditor5-image/src/image/replaceimagesourcecommand.ts

Lines 48 to 49 in 257e0f0

writer.removeAttribute( 'srcset', image );
writer.removeAttribute( 'sizes', image );

Scope

Updating the URL of the responsive image (srcset, sources), should change it to a normal image. We should also clean the ckboxImageId attribute.
@Witoso Witoso added squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. package:image package:ckbox labels Sep 28, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Oct 2, 2023
@illia-stv illia-stv self-assigned this Oct 5, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Oct 5, 2023
@illia-stv illia-stv mentioned this issue Oct 5, 2023
Merged
@pszczesniak pszczesniak self-assigned this Oct 10, 2023
niegowski added a commit that referenced this issue Oct 16, 2023
@niegowski
Merge pull request #15135 from ckeditor/ck/15093-fix-the-url-editing-…
70d7593 
…of-the-responsive-image

Fix (image): Remove outdated image attributes when an image is replaced by a URL. Closes #15093.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 16, 2023
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Oct 16, 2023
@CKEditorBot CKEditorBot mentioned this issue Oct 17, 2023
Open
@Witoso Witoso mentioned this issue Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pszczesniak pszczesniak

@illia-stv illia-stv

Labels
package:ckbox package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 68 (v40.1.0)
Development

Successfully merging a pull request may close this issue.

Remove some attributes in responsive images from ckbox ckeditor/ckeditor5
4 participants
@pszczesniak @Witoso @CKEditorBot @illia-stv