Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the value of --ck-ai-balloon-error-background #15217

Closed
oleq opened this issue Oct 23, 2023 · 0 comments · Fixed by #15218
Closed

Unify the value of --ck-ai-balloon-error-background #15217

oleq opened this issue Oct 23, 2023 · 0 comments · Fixed by #15218
Assignees
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:comments package:theme-lark type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Oct 23, 2023

Provide a description of the task

  • We use two different CSS variable names.
  • We should have one variable name (a generic one) and update in Figma if needed.

Note:

  1. We could have two variable “semantic” names, e.g
    1. --ck-ai-form-error-background
    2. --ck-color-comment-remove-background
  2. But then, we may have one specified color for the system like --ck-light-red
  3. Then, we can do:
    1. --ck-ai-form-error-background: var(--ck-light-red)
  4. This way we have semantic name + unified colors across the application.
@oleq oleq added the type:task This issue reports a chore (non-production change) and other types of "todos". label Oct 23, 2023
@oleq oleq self-assigned this Oct 23, 2023
@oleq oleq added package:comments package:theme-lark domain:dx This issue reports a developer experience problem or possible improvement. labels Oct 23, 2023
DawidKossowski added a commit that referenced this issue Oct 23, 2023
Other (theme-lark): Created a custom property for a shared light red color. Closes #15217.
@CKEditorBot CKEditorBot added this to the iteration 68 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:comments package:theme-lark type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants