Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips content should be copiable after the recent changes #16110

Closed
dufipl opened this issue Mar 27, 2024 · 1 comment · Fixed by #16113
Closed

Tooltips content should be copiable after the recent changes #16110

dufipl opened this issue Mar 27, 2024 · 1 comment · Fixed by #16113
Assignees
@Mati365
Labels
domain:accessibility This issue reports an accessibility problem. squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 74 (v41...

Comments

@dufipl
Copy link
Contributor

dufipl commented Mar 27, 2024

📝 Provide detailed reproduction steps (if any)

  1. Run the editor with the latest master or nightly version e.g. 0.0.0-nightly-20240327.0
  2. Hover a toolbar button and try to copy the tooltip content.

✔️ Expected result

Tooltip content is copiable after the recent changes: #16103

❌ Actual result

The tooltip disappears when clicked:

Nagranie.z.ekranu.2024-03-27.o.12.36.22.mov

📃 Other details

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@dufipl dufipl added type:bug This issue reports a buggy (incorrect) behavior. domain:accessibility This issue reports an accessibility problem. squad:collaboration Issue to be handled by the Collaboration team. labels Mar 27, 2024
@Mati365 Mati365 self-assigned this Mar 27, 2024
@Mati365 Mati365 mentioned this issue Mar 27, 2024
Merged
@Mati365
Copy link
Member

Mati365 commented Mar 28, 2024

@dufipl After discussion, we decided to disable selection in tooltip content. It'll not affect our accessibility (and VPAT report) and will be much easier to implement at this moment.

oleq pushed a commit that referenced this issue Apr 11, 2024
@Mati365
Make tooltips unselectable (#16113)
6404116 
Internal (ui): UI tooltip content should not be selectable. Closes #16110.
@CKEditorBot CKEditorBot added this to the iteration 74 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mati365 Mati365

Labels
domain:accessibility This issue reports an accessibility problem. squad:collaboration Issue to be handled by the Collaboration team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 74 (v41.4.1)
Development

Successfully merging a pull request may close this issue.

Make tooltips unselectable ckeditor/ckeditor5
3 participants
@Mati365 @CKEditorBot @dufipl