Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update framework integrations to ESM #16616

Closed
filipsobol opened this issue Jun 26, 2024 · 0 comments
Closed

Update framework integrations to ESM #16616

filipsobol opened this issue Jun 26, 2024 · 0 comments
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@filipsobol
Copy link
Member

After we migrated the editor to ESM, there appear to be an issue with our React and Vue integrations, which still use UMD and thus require.

We need to update these two integrations to use ESM too.

Related issue: ckeditor/ckeditor5-react#475

@filipsobol filipsobol added the type:bug This issue reports a buggy (incorrect) behavior. label Jun 26, 2024
filipsobol added a commit to ckeditor/ckeditor5-vue that referenced this issue Jul 11, 2024
Fix: Use type of the passed `editor` prop rather than generic `Editor` type. Closes #282.

Internal: Migrate from webpack and Karma to Vite and Vitest. See ckeditor/ckeditor5#16616.

MINOR BREAKING CHANGE: Migrate to ESM. See ckeditor/ckeditor5#16616.

MINOR BREAKING CHANGE: Migrate to Composition API. Closes #172.

MINOR BREAKING CHANGE: Bump required version to Vue 3.4+. See #282.

MINOR BREAKING CHANGE: Export the component as `Ckeditor` instead of `default.component`. Closes #284.

MINOR BREAKING CHANGE: Remove argument from the `destroy` event, as it was always `null`. Closes #283.
filipsobol added a commit to ckeditor/ckeditor5-react that referenced this issue Jul 12, 2024
Internal: Migrate from webpack and Karma to Vite and Vitest. See ckeditor/ckeditor5#16616.

Internal: Fix test coverage which only covered a small portion of the codebase.

MINOR BREAKING CHANGE: Migrate to ESM. Related to ckeditor/ckeditor5#16616.
@Witoso Witoso added squad:core Issue to be handled by the Core team. resolution:resolved This issue was already resolved (e.g. by another ticket). labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants