Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark formatting attributes with a common property #1664

Closed
mlewand opened this issue Mar 29, 2019 · 0 comments
Closed

Mark formatting attributes with a common property #1664

mlewand opened this issue Mar 29, 2019 · 0 comments
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@mlewand
Copy link
Contributor

mlewand commented Mar 29, 2019

Is this a bug report or feature request?

🆕 Feature request

💻 Version of CKEditor

CKEditor v5 @ 12.0.0

📋 Steps to reproduce

With introduction of attribtue properties in #1659 we should mark all the formatting markup with isFormatting property.

That way the remove format feature (#908) will be able to tell which attributes should be removed.

Related pull requests:

@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed labels Mar 29, 2019
@mlewand mlewand added this to the iteration 23 milestone Mar 29, 2019
jodator added a commit to ckeditor/ckeditor5-alignment that referenced this issue Mar 29, 2019
Feature: Marked alignment as a formatting attribute using the `AttributeProperties#isFormatting` property. Closes ckeditor/ckeditor5#1664.
jodator added a commit to ckeditor/ckeditor5-font that referenced this issue Mar 29, 2019
Feature: Marked font size and font family as a formatting attribute using the `AttributeProperties#isFormatting` property. Closes ckeditor/ckeditor5#1664.
jodator added a commit to ckeditor/ckeditor5-basic-styles that referenced this issue Mar 29, 2019
Feature: Marked basic style attributes as a formatting using the `AttributeProperties#isFormatting` property. Closes ckeditor/ckeditor5#1664.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

1 participant