Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release tools - assume npm publish did the job when returns a zero exit code #17348

Closed
pomek opened this issue Oct 29, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#1043
Closed

Release tools - assume npm publish did the job when returns a zero exit code #17348

pomek opened this issue Oct 29, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#1043
Assignees
@psmyrek
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 80 (v44...

Comments

@pomek
Copy link
Member

pomek commented Oct 29, 2024

Provide a description of the task

As in the title, I always worked as expected during manual checks.

We were unlucky when a zero exit code did not publish a package. It never occurred again, so I would like to revert this change:

ckeditor/ckeditor5-dev@a1b37c7#diff-86ad491039b92ef35583d75429beaf0d8d7ac1cce17ac091ff41b52ac4c5a039L16
@pomek pomek added package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Oct 29, 2024
@psmyrek psmyrek mentioned this issue Oct 29, 2024
Merged
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 29, 2024
psmyrek added a commit to ckeditor/ckeditor5-dev that referenced this issue Oct 29, 2024
@psmyrek
Merge pull request #1043 from ckeditor/ck/17348
735d7ec 
Other (release-tools): The `publishPackageOnNpmCallback()` util removes a package directory if npm says it was published. This reverts commit [`a1b37c7`](a1b37c7). Closes ckeditor/ckeditor5#17348.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 29, 2024
@CKEditorBot CKEditorBot added this to the iteration 80 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psmyrek psmyrek

Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 80 (v44.0.0)
Development

Successfully merging a pull request may close this issue.

Remove a package directory when npm says it was published ckeditor/ckeditor5-dev
3 participants
@pomek @CKEditorBot @psmyrek