Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define default setup for manual tests #346

Closed
Reinmar opened this issue Oct 12, 2016 · 1 comment
Closed

Define default setup for manual tests #346

Reinmar opened this issue Oct 12, 2016 · 1 comment
Labels
resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. status:discussion

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 12, 2016

Currently, we've got two types of manual tests:

  1. Ticket tests which require minimal editors (if they require editor at all).
  2. Feature tests where we'd like to have an editor with the standard set of features and, usually, some standard content.

I wonder if it makes sense to standardize the features that you have in those tests. E.g:

    features: getStandardFeatures().concat( [ SpecialOne ] ),
    toolbar: getStandardButtons()

Currently, when a new feature is added, it's not present in other features manual tests, so I often update them manually. Functions like this could solve this. However, should tests use helpers like this? Good practices say that there should be full clarity in tests.

PS. This was a problem now, but perhaps soon, when the standard features will be ready, those tests won't have to change that often. So maybe there's no issue at all.

@Reinmar
Copy link
Member Author

Reinmar commented May 5, 2017

Just like #194 – not a big issue. Also, we use presets now in some tests which lets us import even less stuff.

@Reinmar Reinmar closed this as completed May 5, 2017
@Reinmar Reinmar added the resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. label May 5, 2017
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: Replaced the `.ck-labeled-input` class with `.ck-labeled-field-view` (see #6553).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:wontfix This issue will not be fixed because the team decided that for given reasons it does not make sense. status:discussion
Projects
None yet
Development

No branches or pull requests

1 participant