-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BalloonPanelView should not be focusable #5344
Comments
Isn't that CSS supported by Chrome only? |
Nope. It's supported by almost every major web browser. |
And why is the balloon focusable in the first place? |
Most certainly because the author (me) has never considered this thing becoming a problem and obviously was wrong ;-) |
There must've been some reason. I even recall there was something... But I don't remember what and whether this is still any relevant. Hopefully not... but I remember that CKE4's dialogs were also focusable. |
They aren't. Or at least, they don't look like they accept focus. |
That's odd. I was nearly sure they were. So... I'll better stop confusing you :D |
https://github.com/ckeditor/ckeditor5-ui/blob/master/src/panel/balloon/balloonpanelview.js#L131 |
Maybe we don't need it anymore, hard to tell. |
T/206a: BalloonPanelView should not be focusable
Because of that we end up with problems like https://github.com/ckeditor/ckeditor5-link/issues/90. It's probably just a matter of using the
@mixin ck-unselectable
in SASS.The text was updated successfully, but these errors were encountered: