This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/206: BalloonPanelView should not be focusable #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Additional note for the reviewer: please make sure other features than Link using |
|
I'm not able to select input by a click.
|
oskarwrobel
reviewed
Apr 21, 2017
| tabindex: -1 | ||
| on: { | ||
| // https://github.com/ckeditor/ckeditor5-ui/issues/206 | ||
| mousedown: bind.to( evt => evt.preventDefault() ) |
There was a problem hiding this comment.
This makes impossible to select any text on balloon.
There was a problem hiding this comment.
You couldn't do it anyway because of @mixin ck-unselectable I think.
There was a problem hiding this comment.
Hm. We should probably filter target then. I'll check this out.
|
A better solution in #213. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: BalloonPanelView should not be focusable. Closes ckeditor/ckeditor5#5344.
Additional information
BPVhas@mixin ck-unselectableenabled by default but CSSuser-selectdoes not affect focus.Removing
tabindex="-1"attribute disabled panel focus but it didn't prevent focus loss, so when clicked the panel didn't get focus but editor focus was lost, which was evident in editor-inline.Only
preventDefaultof themousedownevent disabled focus properly and prevented focus loss.