Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y][RTL] Toolbar navigation with the keyboard works in the wrong direction #5585

Closed
oleq opened this issue Oct 14, 2019 · 0 comments · Fixed by #9692
Closed

[A11y][RTL] Toolbar navigation with the keyboard works in the wrong direction #5585

oleq opened this issue Oct 14, 2019 · 0 comments · Fixed by #9692
Assignees
@mateuszzagorski
Labels
domain:accessibility This issue reports an accessibility problem. domain:rtl This issue reports a problem with support for right-to-left languages. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:ui squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 43 (v28...

Comments

@oleq
Copy link
Member

oleq commented Oct 14, 2019

📝 Provide detailed reproduction steps (if any)

  1. Open a classic editor in Arabic,
  2. (Fn+)Alt+F10 to focus the toolbar,
  3. Press the left arrow

✔️ Expected result

  • Focus moves (visually) left, like, for instance in v4.

❌ Actual result

  • Focus moves right because the DOM order is used not the visual order.

📃 Other details

master

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

cc @mlewand
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:ui domain:accessibility This issue reports an accessibility problem. domain:rtl This issue reports a problem with support for right-to-left languages. labels Oct 14, 2019
@Reinmar Reinmar modified the milestones: next, nice-to-have Nov 18, 2019
@oleq oleq added the intro Good first ticket. label Mar 20, 2020
@mlewand mlewand assigned mlewand and mateuszzagorski and unassigned mlewand May 11, 2021
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels May 11, 2021
@mlewand mlewand modified the milestones: nice-to-have, iteration 43 May 11, 2021
@mateuszzagorski mateuszzagorski mentioned this issue May 13, 2021
Merged
@AnnaTomanek AnnaTomanek mentioned this issue May 13, 2021
Closed
mlewand added a commit that referenced this issue May 20, 2021
@mlewand
Merge pull request #9692 from ckeditor/i/5585
2d2e34f 
Fix: Fixed arrow handling with toolbar focused in case RTL language UI. Closes #5585.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mateuszzagorski mateuszzagorski

Labels
domain:accessibility This issue reports an accessibility problem. domain:rtl This issue reports a problem with support for right-to-left languages. domain:ui/ux This issue reports a problem related to UI or UX. intro Good first ticket. package:ui squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 43 (v28.0.0)
Development

Successfully merging a pull request may close this issue.

i/5585: Added support for RTL toolbar keyboard navigation ckeditor/ckeditor5
4 participants
@Reinmar @oleq @mlewand @mateuszzagorski