Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A toolbar with grouped items should have some sane max-width #5586

Closed
oleq opened this issue Oct 15, 2019 · 5 comments · Fixed by #8553
Closed

A toolbar with grouped items should have some sane max-width #5586

oleq opened this issue Oct 15, 2019 · 5 comments · Fixed by #8553
Assignees
@pkwasnik
Labels
intro Good first ticket. package:ui squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 38 (v24...

Comments

@oleq
Copy link
Member

oleq commented Oct 15, 2019

📝 Provide detailed reproduction steps (if any)

  1. Open classic editor.
  2. Make the window very narrow.
  3. Open the toolbar with the items that didn't fit in the single row.

✔️ Expected result

It should never get out of the viewport. It should have some sane max-width and wrap items to the next line.

❌ Actual result

Sometimes it's getting too long and it sticks out.

Peek 2019-10-14 19-05

📃 Other details

Follow-up of ckeditor/ckeditor5-ui#523.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed package:ui labels Oct 15, 2019
@oleq oleq mentioned this issue Oct 15, 2019
Merged
@dkonopka dkonopka mentioned this issue Oct 15, 2019
Closed
@Reinmar Reinmar added this to the backlog milestone Nov 18, 2019
@Mgsy Mgsy mentioned this issue Jun 1, 2020
Closed
@ahmedosama5200
Copy link

ahmedosama5200 commented Jun 1, 2020 •
edited
Loading

any updates ? is this gonna be fixed soon ?

@oleq oleq mentioned this issue Jul 24, 2020
Closed
@oleq oleq mentioned this issue Sep 7, 2020
Closed
@nusagates
Copy link

Fix this please

@oleq oleq added squad:core Issue to be handled by the Core team. intro Good first ticket. labels Sep 8, 2020
@nusagates
Copy link

Still waiting for an update on this issue. 🙏

@snorkellingcactus
Copy link

Same here

@Reinmar
Copy link
Member

Reinmar commented Sep 21, 2020

It would also be good to resolve #6146.

@FilipTokarski FilipTokarski mentioned this issue Oct 1, 2020
Closed
@Reinmar Reinmar mentioned this issue Nov 17, 2020
Closed
@oleq oleq modified the milestones: backlog, iteration 38 Nov 17, 2020
This was referenced Nov 23, 2020
Closed
Closed
@pkwasnik pkwasnik self-assigned this Nov 30, 2020
@pkwasnik pkwasnik mentioned this issue Nov 30, 2020
Merged
@oleq oleq closed this as completed in #8553 Dec 1, 2020
oleq added a commit that referenced this issue Dec 1, 2020
@oleq
Merge pull request #8553 from ckeditor/i/5586
65bc73d 
Fix (ui): A toolbar with grouped items should wrap to keep items visible in the viewport. Closes #5586 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkwasnik pkwasnik

Labels
intro Good first ticket. package:ui squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Wrapping of a toolbar with grouped items. ckeditor/ckeditor5
7 participants
@Reinmar @oleq @snorkellingcactus @mlewand @nusagates @pkwasnik @ahmedosama5200