Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to toggle toolbar items grouping in a build #5692

Closed
changus opened this issue Oct 30, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-core#201
Closed

Add possibility to toggle toolbar items grouping in a build #5692

changus opened this issue Oct 30, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-core#201
Assignees
@oleq
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 28 (v16...

Comments

@changus
Copy link

changus commented Oct 30, 2019

Is there an easy way to implement a multi-row toolbar like in previous ckeditor versions? I like the dynamic grouping, but I am also in need of a multi-row toolbar.

I did not find anything describing this by looking at the documentation or searching the issues, thanks!
@Mgsy
Copy link
Member

Mgsy commented Nov 4, 2019

Hi! There's shouldGroupWhenFull property which toggles grouping, however this toolbar option is passed to the toolbar constructor, so there's no way to change it in the build.

We've decided to add a possibility for toggling grouping in the current iteration.

@Mgsy Mgsy added package:ui status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. labels Nov 4, 2019
@Mgsy Mgsy assigned oleq Nov 4, 2019
@Mgsy Mgsy changed the title Question: Multi-row toolbar Add possibility to toggle toolbar items grouping in a build Nov 4, 2019
@Mgsy Mgsy added this to the iteration 28 milestone Nov 4, 2019
@Mgsy Mgsy mentioned this issue Nov 4, 2019
Closed
This was referenced Nov 18, 2019
Merged
Merged
Merged
Reinmar added a commit to ckeditor/ckeditor5-core that referenced this issue Nov 20, 2019
@Reinmar
Merge pull request #201 from ckeditor/i/5692
3af9e3a 
Docs: Added documentation for the `config.toolbar.shouldGroupWhenFull` option. Closes ckeditor/ckeditor5#5692.
Reinmar added a commit to ckeditor/ckeditor5-editor-classic that referenced this issue Nov 20, 2019
@Reinmar
Merge pull request #100 from ckeditor/i/5692
9a57e63 
Feature: The main editor toolbar should respect the `config.toolbar.shouldNotGroupWhenFull` configuration (see ckeditor/ckeditor5#5692).
Reinmar added a commit to ckeditor/ckeditor5-editor-decoupled that referenced this issue Nov 20, 2019
@Reinmar
Merge pull request #45 from ckeditor/i/5692
35b3cbf 
Feature: The main editor toolbar should respect the `config.toolbar.shouldNotGroupWhenFull` configuration (see ckeditor/ckeditor5#5692).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 28 (v16.0.0)
3 participants
@oleq @changus @Mgsy