Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ImageButton be included in the builds? #570

Closed
Reinmar opened this issue Sep 29, 2017 · 3 comments
Closed

Should ImageButton be included in the builds? #570

Reinmar opened this issue Sep 29, 2017 · 3 comments
Labels
status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 29, 2017

Extracted from #567.

me:

Should the "Insert image" button be available in those builds too? I know that it should not appear automatically in the toolbar, but should the plugin be enabled?

@wwalc:

Shouldn't we track it in a separate ticket as it's a completely separate issue?
The original issue was about two particular plugins which were already included, hence this issue could be closed.

The new issue could be about the Image Button and our strategy towards it. For example I have some concerns regarding mobiles. On mobiles the only reasonable way to insert an image is a toolbar button. If it's not available in Builds by default then there is a "?" regarding basic support for mobiles by CKEditor 5 Builds

@Reinmar Reinmar added candidate:1.0.0 status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Sep 29, 2017
@fredck
Copy link
Contributor

fredck commented Oct 2, 2017

So we must also check how this button behaves on mobiles, first of all. I'm curious to see it.

@fredck
Copy link
Contributor

fredck commented Oct 2, 2017

As a first feeling, I would be for including the plugin in the build but not in the toolbar configuration, leaving the implementor one config away from having it.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 5, 2018

The button was added to all builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

2 participants