Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable missing features in CKEditor 5 builds #567

Closed
wwalc opened this issue Sep 27, 2017 · 4 comments
Closed

Enable missing features in CKEditor 5 builds #567

wwalc opened this issue Sep 27, 2017 · 4 comments
Assignees
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@wwalc
Copy link
Member

wwalc commented Sep 27, 2017

@Reinmar
Copy link
Member

Reinmar commented Sep 29, 2017

Should the "Insert image" button be available in those builds too? I know that it should not appear automatically in the toolbar, but should the plugin be enabled?

Please note that I'm asking for the future, because by a mistake, ImageUploadButton is now automatically loaded by ImageUpload plugin. This will change together with https://github.com/ckeditor/ckeditor5-upload/issues/22.

@Reinmar Reinmar self-assigned this Sep 29, 2017
@Reinmar Reinmar added candidate:1.0.0 type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Sep 29, 2017
@Reinmar Reinmar added this to the iteration 12 milestone Sep 29, 2017
@wwalc
Copy link
Member Author

wwalc commented Sep 29, 2017

Shouldn't we track it in a separate ticket as it's a completely separate issue?
The original issue was about two particular plugins which were already included, hence this issue could be closed.

The new issue could be about the Image Button and our strategy towards it. For example I have some concerns regarding mobiles. On mobiles the only reasonable way to insert an image is a toolbar button. If it's not available in Builds by default then there is a "?" regarding basic support for mobiles by CKEditor 5 Builds.

@Reinmar
Copy link
Member

Reinmar commented Sep 29, 2017

Shouldn't we track it in a separate ticket as it's a completely separate issue?

If it turns out that complicated choice then yes. Here you are: #570

Reinmar added a commit to ckeditor/ckeditor5-build-classic that referenced this issue Sep 29, 2017
Reinmar added a commit to ckeditor/ckeditor5-build-inline that referenced this issue Sep 29, 2017
Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Sep 29, 2017
@Reinmar
Copy link
Member

Reinmar commented Sep 29, 2017

@Reinmar Reinmar closed this as completed Sep 29, 2017
JDinABox pushed a commit to JDinABox/ckeditor5-build-markdown that referenced this issue Sep 6, 2021
rivernews pushed a commit to rivernews/ckeditor5-build-balloon-2022 that referenced this issue Dec 31, 2021
fl01337 pushed a commit to fl01337/ckeditor-5-build-inline that referenced this issue May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

2 participants