Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricted editing boundary can be crossed with a command which operates on more than the current selection #5840

Closed
Reinmar opened this issue Nov 27, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-restricted-editing#7
Assignees
Labels
package:restricted-editing type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Reinmar
Copy link
Member

Reinmar commented Nov 27, 2019

There are two commands that come to my mind:

  • unlinking
  • delete word

Content that will break:

image

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Nov 27, 2019
@Reinmar Reinmar added this to the iteration 29 milestone Nov 27, 2019
@jodator
Copy link
Contributor

jodator commented Nov 28, 2019

Reported by @oleq:

  1. Go to restricted mode
  2. Put the caret at the beginning of an editable (exception) area
  3. Click “Link”
  4. The link is inserted before the exception (the exception should be included)

type some link and save.

@jodator
Copy link
Contributor

jodator commented Nov 28, 2019

Another case (Firefox, native spell check):

Peek 2019-11-28 08-51

The native spell check did not fix "computter" when the action was performed on the part outside the exception. When performed on part in exception we get word changed outside the marker.

Words on Chrome are treted separately if divided by <span> (marker). I was unable to fix a word outside the exception marker.

@jodator
Copy link
Contributor

jodator commented Nov 28, 2019

And also Safari does weird things with fixed words:

  1. put selection at the end of an exception marker
  2. write " cooool"
  3. press space
  4. the word get fixed to cool but "l" is out of the exception marker

@jodator jodator self-assigned this Dec 2, 2019
Reinmar added a commit to ckeditor/ckeditor5-restricted-editing that referenced this issue Dec 19, 2019
Fix: Restricted editing boundaries should not be crossed by delete content and input command. Closes ckeditor/ckeditor5#5840.
jodator added a commit to ckeditor/ckeditor5-restricted-editing that referenced this issue Jan 29, 2020
Fix: Restricted editing boundaries should not be crossed by attribute operations. See ckeditor/ckeditor5#5840.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment