Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align table properties UI to multi-range selection #6150

Closed
jodator opened this issue Jan 28, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-table#253
Closed

Align table properties UI to multi-range selection #6150

jodator opened this issue Jan 28, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-table#253
Assignees
@jodator
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 30 (v18...

Comments

@jodator
Copy link
Contributor

jodator commented Jan 28, 2020 •
edited by Reinmar
Loading

Cases to cover:

  • apply styles to all selected table cells
  • display value from range of cells in the UI (if different values in the selected cells, let's display... as undefined – this is – no value set; we can improve this later on)

Decide:

  • how to pass value to UI (multiple cells selected)
@jodator jodator added domain:ui/ux This issue reports a problem related to UI or UX. package:table type:improvement This issue reports a possible enhancement of an existing feature. labels Jan 28, 2020
@jodator jodator added this to the iteration 30 milestone Jan 28, 2020
@Reinmar Reinmar mentioned this issue Jan 31, 2020
Closed
21 tasks
@Reinmar Reinmar changed the title Align table styles UI to multi-range selection Align table properties UI to multi-range selection Feb 21, 2020
@jodator jodator self-assigned this Feb 24, 2020
@jodator
Copy link
Contributor Author

jodator commented Feb 24, 2020

Decide:

  • how to pass value to UI (multiple cells selected)

I would propose below:

  1. Command#value - behaves like a "single" value command - it is set to some value if all selected table cells have the same value (isn't coherent with other commands that would return value from first selected block)

  2. Command#values (or other name) is an array of values for all selected table cells.

Side note: Similar API could be introduced in other commands but I don't see a common API for this (ie Bold command #values would be ambiguous.

This was referenced Feb 24, 2020
Closed
Merged
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Feb 28, 2020
@Reinmar
Merge pull request #253 from ckeditor/i/6150
52acb0c 
Feature: Table cell properties form should handle multi-cell selections. Closes ckeditor/ckeditor5#6150.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

Successfully merging a pull request may close this issue.

I/6150: Make table cell properties UI aware of mult-cell selection. ckeditor/ckeditor5-table
1 participant
@jodator